Change in coreboot[master]: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef
Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35543 )
Change subject: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef ......................................................................
mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef
This removes the "ifdef ACPI" which is not needed here as we currently don't include gpio.h in any asl file.
Change-Id: I803bbee5933eda9423a9bc9fcaea9e905e3ac78e Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35543/1
diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h index a5eed6b..83fb22d 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h @@ -19,7 +19,6 @@ #include <soc/gpe.h> #include <soc/gpio.h>
-#ifndef __ACPI__ static const struct pad_config gpio_table[] = { /* RCIN# */ _PAD_CFG_STRUCT(GPP_A0, 0x44000702, 0x00000000), /* LAD0 */ _PAD_CFG_STRUCT(GPP_A1, 0x44000702, 0x00000000), @@ -244,5 +243,4 @@ /* CLKOUT_LPC1 */ _PAD_CFG_STRUCT(GPP_A10, 0x44000700, 0x00000000), };
-#endif /* __ACPI__ */ #endif /* _GPIO_X11SSH_TF_H */
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35543
to look at the new patch set (#4).
Change subject: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef ......................................................................
mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef
This removes the "ifdef ACPI" which is not needed here as we currently don't include gpio.h in any asl file.
Change-Id: I803bbee5933eda9423a9bc9fcaea9e905e3ac78e Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35543/4
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35543
to look at the new patch set (#5).
Change subject: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef ......................................................................
mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef
This removes the "ifdef ACPI" which is not needed here as we currently don't include gpio.h in any asl file.
Change-Id: I803bbee5933eda9423a9bc9fcaea9e905e3ac78e Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35543/5
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35543
to look at the new patch set (#6).
Change subject: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef ......................................................................
mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef
This removes the "ifdef ACPI" which is not needed here as we currently don't include gpio.h in any asl file.
Change-Id: I803bbee5933eda9423a9bc9fcaea9e905e3ac78e Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35543/6
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35543
to look at the new patch set (#7).
Change subject: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef ......................................................................
mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef
This removes the "ifdef ACPI" which is not needed here as we currently don't include gpio.h in any asl file.
Change-Id: I803bbee5933eda9423a9bc9fcaea9e905e3ac78e Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35543/7
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35543
to look at the new patch set (#9).
Change subject: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef ......................................................................
mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef
This removes the "ifdef ACPI" which is not needed here as we currently don't include gpio.h in any asl file.
Change-Id: I803bbee5933eda9423a9bc9fcaea9e905e3ac78e Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/35543/9
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35543 )
Change subject: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef ......................................................................
Patch Set 10: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35543 )
Change subject: mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef ......................................................................
mb/supermicro/x11-lga1151-series: x11ssh-tf: remove unneeded ACPI ifdef
This removes the "ifdef ACPI" which is not needed here as we currently don't include gpio.h in any asl file.
Change-Id: I803bbee5933eda9423a9bc9fcaea9e905e3ac78e Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/35543 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h index a5eed6b..83fb22d 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h @@ -19,7 +19,6 @@ #include <soc/gpe.h> #include <soc/gpio.h>
-#ifndef __ACPI__ static const struct pad_config gpio_table[] = { /* RCIN# */ _PAD_CFG_STRUCT(GPP_A0, 0x44000702, 0x00000000), /* LAD0 */ _PAD_CFG_STRUCT(GPP_A1, 0x44000702, 0x00000000), @@ -244,5 +243,4 @@ /* CLKOUT_LPC1 */ _PAD_CFG_STRUCT(GPP_A10, 0x44000700, 0x00000000), };
-#endif /* __ACPI__ */ #endif /* _GPIO_X11SSH_TF_H */
-
Michael Niewöhner (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)