Attention is currently required from: Jakub Czapiga, Julius Werner.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59492 )
Change subject: libpayload: Add libpayload_boot_device_read function
......................................................................
Patch Set 2:
(2 comments)
File payloads/libpayload/include/boot_device.h:
https://review.coreboot.org/c/coreboot/+/59492/comment/146a63d6_35e29390
PS2, Line 1: GPS
GPL?
https://review.coreboot.org/c/coreboot/+/59492/comment/ddcd00d3_13699b8e
PS2, Line 20: libpayload_boot_device_read
I'm not that happy with the name, especially since it has to be implemented by payloads. callback_boot_device_read(), perhaps? (also not too happy about that idea)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1babd2a8414ed9de3ca49903fcb4f036997b5ff3
Gerrit-Change-Number: 59492
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 30 Nov 2021 17:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment