[S] Change in coreboot[main]: intel/alderlake: Drop redundant Client/AlderLake* FSP paths
Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Nico Huber, Rishika Raj, Ronak Kanabar.
Subrata Banik has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/83826?usp=email )
Change subject: intel/alderlake: Drop redundant Client/AlderLake* FSP paths ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/83826/comment/e10e796f_d889bca8?usp... : PS1, Line 413: default "3rdparty/fsp/AlderLakeFspBinPkg/Client/AlderLakeP/Include/" if SOC_INTEL_ALDERLAKE_PCH_P && !SOC_INTEL_RAPTORLAKE
As the commit message suggest, both paths are the same (with the current submodule pointer). So what you describe would already be broken since the submodule update, wouldn't it?
Exactly. we need to ensure we are not forcing everyone to switch to converged FW (RPL) unless there is a need hence, ADL platform should point to ADL FSP repo.
$ ls -l 3rdparty/fsp/AlderLakeFspBinPkg/Client/ insgesamt 4 lrwxrwxrwx 1 icon users 44 8. Aug 12:19 AlderLakeP -> ../../RaptorLakeFspBinPkg/Client/RaptorLakeP/ lrwxrwxrwx 1 icon users 44 8. Aug 12:19 AlderLakeS -> ../../RaptorLakeFspBinPkg/Client/RaptorLakeS/ -rw-r--r-- 1 icon users 759 8. Aug 12:19 README.md
-
Subrata Banik (Code Review)