Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37399 )
Change subject: mb/lenovo/t530/devicetree: Use subsystemid inheritance ......................................................................
mb/lenovo/t530/devicetree: Use subsystemid inheritance
Missing PCI IDs are checked against those collected at https://github.com/linuxhw/LsPCI/tree/master/Notebook/Lenovo/ThinkPad.
Change-Id: I61457b7a791dc3341d582f67e651acc6230c525c Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t530/variants/t530/devicetree.cb 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/37399/1
diff --git a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb index 190539a..47e40c3 100644 --- a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb @@ -37,6 +37,8 @@ register "pci_mmio_size" = "2048"
device domain 0 on + subsystemid 0x17aa 0x21f6 inherit + device pci 00.0 on end # host bridge device pci 01.0 on end # PCIe Bridge for discrete graphics device pci 02.0 on end # vga controller @@ -77,7 +79,9 @@ device pci 16.1 off end # Management Engine Interface 2 device pci 16.2 off end # Management Engine IDE-R device pci 16.3 off end # Management Engine KT - device pci 19.0 on end # Intel Gigabit Ethernet + device pci 19.0 on # Intel Gigabit Ethernet + subsystemid 0x17aa 0x21f3 + end device pci 1a.0 on end # USB2 EHCI #2 device pci 1b.0 on end # High Definition Audio device pci 1c.0 on end # PCIe Port #1
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37399 )
Change subject: mb/lenovo/t530/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 6: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37399 )
Change subject: mb/lenovo/t530/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 6: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37399 )
Change subject: mb/lenovo/t530/devicetree: Use subsystemid inheritance ......................................................................
mb/lenovo/t530/devicetree: Use subsystemid inheritance
Missing PCI IDs are checked against those collected at https://github.com/linuxhw/LsPCI/tree/master/Notebook/Lenovo/ThinkPad.
Change-Id: I61457b7a791dc3341d582f67e651acc6230c525c Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37399 Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/t530/variants/t530/devicetree.cb 1 file changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb index 190539a..47e40c3 100644 --- a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb @@ -37,6 +37,8 @@ register "pci_mmio_size" = "2048"
device domain 0 on + subsystemid 0x17aa 0x21f6 inherit + device pci 00.0 on end # host bridge device pci 01.0 on end # PCIe Bridge for discrete graphics device pci 02.0 on end # vga controller @@ -77,7 +79,9 @@ device pci 16.1 off end # Management Engine Interface 2 device pci 16.2 off end # Management Engine IDE-R device pci 16.3 off end # Management Engine KT - device pci 19.0 on end # Intel Gigabit Ethernet + device pci 19.0 on # Intel Gigabit Ethernet + subsystemid 0x17aa 0x21f3 + end device pci 1a.0 on end # USB2 EHCI #2 device pci 1b.0 on end # High Definition Audio device pci 1c.0 on end # PCIe Port #1