Attention is currently required from: Angel Pons, Arthur Heymans. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/63071
to review the following change.
Change subject: nb/intel/snb/raminit_mrc.c: Remove set but unused variable ......................................................................
nb/intel/snb/raminit_mrc.c: Remove set but unused variable
Change-Id: I1cf656b404b0e880c061b273ef259ca40a6d499a Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/sandybridge/raminit_mrc.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/63071/1
diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index fbb2b6e..2693afb 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -392,7 +392,7 @@
void setup_sdram_meminfo(struct pei_data *pei_data) { - u32 addr_decoder_common, addr_decode_ch[2]; + u32 addr_decode_ch[2]; struct memory_info *mem_info; struct dimm_info *dimm; int dimm_size; @@ -402,7 +402,6 @@ mem_info = cbmem_add(CBMEM_ID_MEMINFO, sizeof(struct memory_info)); memset(mem_info, 0, sizeof(struct memory_info));
- addr_decoder_common = mchbar_read32(MAD_CHNL); addr_decode_ch[0] = mchbar_read32(MAD_DIMM_CH0); addr_decode_ch[1] = mchbar_read32(MAD_DIMM_CH1);