Change in coreboot[master]: mainboard/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34655 )
Change subject: mainboard/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB ......................................................................
mainboard/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB
HDA is not configured. Enable SOC_INTEL_COMMON_BLOCK_HDA_VERB to configure the HDA using cim_verb_data[] table.
BUG=N/A TEST=Boot Embedded Linux 4.20 on Facebook FBG-1701
Change-Id: I9bb542091ad200833894431f5b840f48dd388173 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/34655/1
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 95d8f6c..7904399 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -23,6 +23,7 @@ select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM2 select SOC_INTEL_BRASWELL + select SOC_INTEL_COMMON_BLOCK_HDA_VERB select PCIEXP_L1_SUB_STATE select HAVE_FSP_BIN select CACHE_MRC_SETTINGS
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34655
to look at the new patch set (#2).
Change subject: mb/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB ......................................................................
mb/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB
HDA is not configured. Enable SOC_INTEL_COMMON_BLOCK_HDA_VERB to configure the HDA using cim_verb_data[] table.
BUG=N/A TEST=Boot Embedded Linux 4.20 on Facebook FBG-1701
Change-Id: I9bb542091ad200833894431f5b840f48dd388173 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/34655/2
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34655 )
Change subject: mb/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB ......................................................................
Patch Set 2:
Which verb table had been loaded? Did the test will including dump verb table in OS level and confirm that's what codec vendor provided?
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34655 )
Change subject: mb/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34655 )
Change subject: mb/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB ......................................................................
mb/facebook/fbg1701: Select SOC_INTEL_COMMON_BLOCK_HDA_VERB
HDA is not configured. Enable SOC_INTEL_COMMON_BLOCK_HDA_VERB to configure the HDA using cim_verb_data[] table.
BUG=N/A TEST=Boot Embedded Linux 4.20 on Facebook FBG-1701
Change-Id: I9bb542091ad200833894431f5b840f48dd388173 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34655 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 177393e..ce90758 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -23,6 +23,7 @@ select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM2 select SOC_INTEL_BRASWELL + select SOC_INTEL_COMMON_BLOCK_HDA_VERB select PCIEXP_L1_SUB_STATE select HAVE_FSP_BIN select CACHE_MRC_SETTINGS
-
Felix Held (Code Review) -
Frans Hendriks (Code Review)
-
Lance Zhao (Code Review)
-
Martin Roth (Code Review)