Attention is currently required from: Tim Wawrzynczak, Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62921 )
Change subject: commonlib/bsd/helpers: Move STRINGIFY() from string.h ......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/helpers.h:
https://review.coreboot.org/c/coreboot/+/62921/comment/48e7e6bc_77361c8d PS2, Line 15: #define ALIGN(x, a) __ALIGN_MASK(x, (__typeof__(x))(a)-1UL) ALIGN(), ALIGN_UP(), GiB, etc. are conflicting with libpayload's defines when included in <\commonlib/timestamp_sierialized.h -> commonlib/bsd/helpers.h. Fail can be seen in CB:62709. Should it these defines be guarded with #ifndef? Or maybe it would be easier to just leave STRINGIFY() in string.h of coreboot and redefine it in timestamp_serialized.h just for this(CB:62709) case?
-
Jakub Czapiga (Code Review)