Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46643 )
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
mb/google/octopus/var/fleex: Add new SKU for LTE touch
BUG=b:168001586 BRANCH=octopus TEST=Check no SAR table can be loaded with sku id 4 and 5.
Change-Id: Ic0405d3e52aa813bbb1f350966a9e2825e595ce4 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46643/1
diff --git a/src/mainboard/google/octopus/variants/fleex/variant.c b/src/mainboard/google/octopus/variants/fleex/variant.c index f1ec818..fcc8be0 100644 --- a/src/mainboard/google/octopus/variants/fleex/variant.c +++ b/src/mainboard/google/octopus/variants/fleex/variant.c @@ -5,11 +5,9 @@ #include <ec/google/chromeec/ec.h> #include <sar.h>
-#define LTE_SKU 4 - static bool is_lte_sku(void) { - return (google_chromeec_get_board_sku() == LTE_SKU); + return (google_chromeec_get_board_sku() > 3); }
void variant_smi_sleep(u8 slp_typ)
Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Ivy Jian, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46643
to look at the new patch set (#2).
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
mb/google/octopus/var/fleex: Add new SKU for LTE touch
New SKU ID 5 is used for LTE touch SKU. This patch does LTE power off for LTE sku and only use Wifi SAR table for non-LTE sku.
BUG=b:168001586 BRANCH=octopus TEST=Check no SAR table can be loaded with sku id 4 and 5.
Change-Id: Ic0405d3e52aa813bbb1f350966a9e2825e595ce4 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46643/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46643 )
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46643/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/46643/2/src/mainboard/google/octopu... PS2, Line 8: #define LTE_SKU 4 Change to MIN_LTE_SKU
https://review.coreboot.org/c/coreboot/+/46643/2/src/mainboard/google/octopu... PS2, Line 12: ==
=
Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Ivy Jian, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46643
to look at the new patch set (#3).
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
mb/google/octopus/var/fleex: Add new SKU for LTE touch
New SKU ID 5 is used for LTE touch SKU. This patch does LTE power off for LTE sku and only use Wifi SAR table for non-LTE sku.
BUG=b:168001586 BRANCH=octopus TEST=Check no SAR table can be loaded with sku id 4 and 5.
Change-Id: Ic0405d3e52aa813bbb1f350966a9e2825e595ce4 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/46643/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46643 )
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
Patch Set 3: Code-Review+2
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46643 )
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46643/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/46643/2/src/mainboard/google/octopu... PS2, Line 8: #define LTE_SKU 4
Change to MIN_LTE_SKU
Done
https://review.coreboot.org/c/coreboot/+/46643/2/src/mainboard/google/octopu... PS2, Line 12: ==
=
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46643 )
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
mb/google/octopus/var/fleex: Add new SKU for LTE touch
New SKU ID 5 is used for LTE touch SKU. This patch does LTE power off for LTE sku and only use Wifi SAR table for non-LTE sku.
BUG=b:168001586 BRANCH=octopus TEST=Check no SAR table can be loaded with sku id 4 and 5.
Change-Id: Ic0405d3e52aa813bbb1f350966a9e2825e595ce4 Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46643 Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/fleex/variant.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/fleex/variant.c b/src/mainboard/google/octopus/variants/fleex/variant.c index f1ec818..522faa9 100644 --- a/src/mainboard/google/octopus/variants/fleex/variant.c +++ b/src/mainboard/google/octopus/variants/fleex/variant.c @@ -5,11 +5,11 @@ #include <ec/google/chromeec/ec.h> #include <sar.h>
-#define LTE_SKU 4 +#define MIN_LTE_SKU 4
static bool is_lte_sku(void) { - return (google_chromeec_get_board_sku() == LTE_SKU); + return (google_chromeec_get_board_sku() >= MIN_LTE_SKU); }
void variant_smi_sleep(u8 slp_typ)
Attention is currently required from: Amanda Hwang. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46643 )
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/46643/comment/4f226a92_b685cd97 PS4, Line 12: return (google_chromeec_get_board_sku() >= MIN_LTE_SKU); * Note that fleex variant supports not only Fleex but also grabbiter and orbatrix which SKU IDs are all bigger than 4. As a result, the CL here caused SRA table is not loaded for grabbiter and orbatrix.
* b/181946744 is created for this issue.
Attention is currently required from: Amanda Hwang. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46643 )
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/46643/comment/731b2c60_f386ce69 PS4, Line 12: return (google_chromeec_get_board_sku() >= MIN_LTE_SKU);
- Note that fleex variant supports not only Fleex but also grabbiter and orbatrix which SKU IDs are […]
Noted, will come up fix soon.
-
Amanda Hwang (Code Review) -
EricR Lai (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)