Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40308 )
Change subject: drivers/ocp/dmi: Add OCP_DMI driver for populating SMBIOS from IPMI FRU data
......................................................................
Patch Set 44:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40308/44//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40308/44//COMMIT_MSG@12
PS44, Line 12: Need to configure the correct values for FRU_DEVICE_ID and BMC_KCS_BASE.
"Mainboard needs to configure"
https://review.coreboot.org/c/coreboot/+/40308/44/src/drivers/ocp/dmi/ocp_dm...
File src/drivers/ocp/dmi/ocp_dmi.h:
https://review.coreboot.org/c/coreboot/+/40308/44/src/drivers/ocp/dmi/ocp_dm...
PS44, Line 6: #include <cpu/x86/msr.h>
Do we need to include this header file?
https://review.coreboot.org/c/coreboot/+/40308/44/src/drivers/ocp/dmi/ocp_dm...
PS44, Line 15: extern msr_t xeon_sp_ppin[];
All the PPIN related code are x86 specific. It should be guarded with CONFIG_ARCH_X86; while hardware access code should part of soc code, instead of here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c958dfad83216cd12545760a19d205efc2515b
Gerrit-Change-Number: 40308
Gerrit-PatchSet: 44
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Jun 2020 00:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment