Attention is currently required from: Nico Huber, Subrata Banik, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60721 )
Change subject: soc/intel/common/cse: Add config to disable CSE at pre-boot
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/60721/comment/de245c97_1113ae64
PS2, Line 13: This config decides the state of CSE/Heci1 device at the end of boot.
DISABLE_HECI1 sounds good. […]
I also wouldn't use "CSE" in the name, since for me CSE refers to the firmware, some internals of it or the hardware part and this is just about the communication interface. However, I would just use HECI1.
Also, I wouldn't invert the option. I think we should be more consistent regarding the direction (enable or disable) of options. If find it pretty hard and also annoying to use the Kconfig menu if some have "enable" and others "disable" in their name. From my perspective, people expect the "enable" terminology in user interfaces. So I would name it "Enable HECI1" and set it to enable by default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60721
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e127816c506df3ac0cf973b69021d02d05bef4a
Gerrit-Change-Number: 60721
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 04 Jan 2022 16:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment