Martin Roth has posted comments on this change. ( https://review.coreboot.org/27268 )
Change subject: stoneyridge: Enable legacy IO ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/27268/1/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/27268/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 378: static void sb_enable_legacy_io(void) I'm fine with this, but did you consider doing both at the same time since it's the same register? sb_pm_decode_setup();