Change in ...coreboot[master]: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in ...coreboot[master]:...

Arthur Heymans (Code Review)

25 Feb 2019 25 Feb '19

12:18 a.m.

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31600

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

[UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info

Fixes microcode not being updated.

Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/intel/model_1067x/mp_init.c 1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/31600/1

diff --git a/src/cpu/intel/model_1067x/mp_init.c b/src/cpu/intel/model_1067x/mp_init.c index acd56c8..1a6110b 100644 --- a/src/cpu/intel/model_1067x/mp_init.c +++ b/src/cpu/intel/model_1067x/mp_init.c @@ -49,6 +49,13 @@ smm_initialize(); }

+static void get_microcode_info(const void **microcode, int *parallel) +{ + microcode_patch = intel_microcode_find(); + *microcode = microcode_patch; + *parallel = 1; +} + #define SMRR_SUPPORTED (1 << 11)

static void per_cpu_smm_trigger(void) @@ -98,6 +105,7 @@ .pre_mp_init = pre_mp_init, .get_cpu_count = get_cpu_count, .get_smm_info = smm_info, + .get_microcode_info = get_microcode_info, .pre_mp_smm_init = pre_mp_smm_init, .per_cpu_smm_trigger = per_cpu_smm_trigger, .relocation_handler = smm_relocation_handler,

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Angel Pons (Code Review)

25 Feb 25 Feb

8:06 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

Will test on G41M-S3 with a Pentium E5200 or something model_1067x

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 25 Feb 2019 07:06:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

9:34 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

...

Patch Set 1:

Will test on G41M-S3 with a Pentium E5200 or something model_1067x

This code is used for model_fxx, model_6ex and model_6fx too.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 25 Feb 2019 08:34:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

27 Feb 27 Feb

1:07 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

...

...
Will test on G41M-S3 with a Pentium E5200 or something model_1067x

This code is used for model_fxx, model_6ex and model_6fx too.

The former have the update already applied early on the BSP, right?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 27 Feb 2019 12:07:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

1:14 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

Also, just noticed, f3x seems to have some `!IS_ENABLED( CONFIG_PARALLEL_MP)` left, that is unreachable now? Or is it still used?

It's only selected by LGA775 and that only together with X4X/I945, AFAICS.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 27 Feb 2019 12:14:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

1:16 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

...

Patch Set 1:

...
...
Will test on G41M-S3 with a Pentium E5200 or something model_1067x

This code is used for model_fxx, model_6ex and model_6fx too.

The former have the update already applied early on the BSP, right?

There is some code to update the BSP microcode in the CAR setup, https://review.coreboot.org/c/coreboot/+/30775 but currently it is not done.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 27 Feb 2019 12:16:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

1:36 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

...

Patch Set 1:

Also, just noticed, f3x seems to have some `!IS_ENABLED( CONFIG_PARALLEL_MP)` left, that is unreachable now? Or is it still used?

It's only selected by LGA775 and that only together with X4X/I945, AFAICS.

I must have missed that... That CPU is not used by non-LGA775 anymore so that code can indeed be removed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 27 Feb 2019 12:36:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:49 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

Is that a regression, or were microcode updates never applied by coreboot with these processors?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 Feb 2019 12:49:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

2:10 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

...

Patch Set 1:

Is that a regression, or were microcode updates never applied by coreboot with these processors?

This fixes a regression indeed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 27 Feb 2019 13:10:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Masanori Ogino (Code Review)

28 Feb 28 Feb

10:07 a.m.

Masanori Ogino has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1: Code-Review+1

Tested on X60s (Core Solo U1300) with SeaBIOS, Linux 4.19.0 (Debian Buster) boots successfully and the microcode is loaded without OS's microcode package installed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Masanori Ogino masanori.ogino@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 28 Feb 2019 09:07:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

10:34 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1: Code-Review+1

...

Patch Set 1:

...
Patch Set 1:

Is that a regression, or were microcode updates never applied by coreboot with these processors?

This fixes a regression indeed.

Could you please update the commit message accordingly?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Masanori Ogino masanori.ogino@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Thu, 28 Feb 2019 09:34:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

11:26 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1:

Complete fix and confirmed working: CB:31664

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Masanori Ogino masanori.ogino@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Thu, 28 Feb 2019 22:26:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Masanori Ogino (Code Review)

4 Mar 4 Mar

5:24 a.m.

Masanori Ogino has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Patch Set 1: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Masanori Ogino masanori.ogino@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Mon, 04 Mar 2019 04:24:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

13 Oct 13 Oct

8:15 p.m.

New subject: Change in coreboot[master]: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31600 )

Change subject: [UNTESTED]cpu/intel/model_1067x/mp_init: Implement get_microcode_info ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/31600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee7a3897362b63bc6d7b9827da47c1cb24135278 Gerrit-Change-Number: 31600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: abandon

1868

days inactive

2099

days old

coreboot-gerrit@coreboot.org

13 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Masanori Ogino (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)