Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85775?usp=email )
Change subject: mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F ......................................................................
mb/google/fatcat/var/francka: Use RAM ID 2 for MT62F2G32D4DS-020 WT:F
Change the ram_id to 2 for MT62F2G32D4DS-020 WT:F based on the hardware schematic MB_SCH_1224A.
BUG=b:372395010 TEST=Run part_id_gen tool and check the generated files.
Change-Id: Ia486d892fca0ed2a9e3e869b97b43af617ef17ac Signed-off-by: Amanda Huang amanda_hwang@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85775 Reviewed-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk M src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt M src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt 3 files changed, 4 insertions(+), 3 deletions(-)
Approvals: Dtrain Hsu: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk b/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk index 310ef55..b18b9c4 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk +++ b/src/mainboard/google/fatcat/variants/francka/memory/Makefile.mk @@ -5,4 +5,5 @@
SPD_SOURCES = SPD_SOURCES += spd/lp5/set-0/spd-empty.hex # ID = 0(0b0000) -SPD_SOURCES += spd/lp5/set-0/spd-10.hex # ID = 1(0b0001) Parts = MT62F2G32D4DS-020 WT:F +SPD_SOURCES += spd/lp5/set-0/spd-empty.hex # ID = 1(0b0001) +SPD_SOURCES += spd/lp5/set-0/spd-10.hex # ID = 2(0b0010) Parts = MT62F2G32D4DS-020 WT:F diff --git a/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt b/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt index dcb790a..3d31714 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt +++ b/src/mainboard/google/fatcat/variants/francka/memory/dram_id.generated.txt @@ -4,4 +4,4 @@ # util/spd_tools/bin/part_id_gen PTL lp5 src/mainboard/google/fatcat/variants/francka/memory src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt
DRAM Part Name ID to assign -MT62F2G32D4DS-020 WT:F 1 (0001) +MT62F2G32D4DS-020 WT:F 2 (0010) diff --git a/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt b/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt index 9b80035..09d6e0b 100644 --- a/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt +++ b/src/mainboard/google/fatcat/variants/francka/memory/mem_parts_used.txt @@ -9,4 +9,4 @@ # See util/spd_tools/README.md for more details and instructions.
# Part Name -MT62F2G32D4DS-020 WT:F,1 +MT62F2G32D4DS-020 WT:F,2