Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57070 )
Change subject: mb/google/volteer: write tcss config to coreboot tables ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/volteer/variants/volteer2/variant.c:
https://review.coreboot.org/c/coreboot/+/57070/comment/f0a1af08_efaf5d9a PS1, Line 47: /* Initialize port 0 information */ : info[0].usb2_port_number = 9; : info[0].usb3_port_number = 1; : info[0].sbu_orientation = TYPEC_ORIENTATION_FOLLOW_CC; : info[0].hsl_orientation = TYPEC_ORIENTATION_FOLLOW_CC; : : /* Initialize port 1 information */ : info[1].usb2_port_number = 4; : info[1].usb3_port_number = 2; : info[1].sbu_orientation = TYPEC_ORIENTATION_FOLLOW_CC; : info[1].hsl_orientation = TYPEC_ORIENTATION_FOLLOW_CC; : This information is already present in devicetree.cb: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
I don't think we should repeat it again in .c files. Ideally, I think this table should be filled/generated by drivers/intel/pmc_mux?