Change in coreboot[master]: mb/google/octopus: add ALC5682I-VS to be supported in the SSFC

[Paul2 Huang (Code Review)]

Attention is currently required from: Henry Sun, Paul Menzel, Marco Chen.
Paul2 Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59856 )

Change subject: mb/google/octopus: add ALC5682I-VS to be supported in the SSFC
......................................................................

Patch Set 6:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/59856/comment/b115806a_d5ce1bbe 
PS5, Line 7: add audio codec into SSFC support for ApelE
> We already have audio codec in SSFC so maybe this CL just `add ALC5682I-VS to be supported in the SS […]

Done

https://review.coreboot.org/c/coreboot/+/59856/comment/4d2d3801_609efda8 
PS5, Line 11: Define SSFC BIT9-11 for codec selection
> This CL didn't define SSFC bits but just add new codec support into existed bits.

Done

https://review.coreboot.org/c/coreboot/+/59856/comment/f5a1c25b_c95f0f69 
PS5, Line 9: Add ALC5682I-VS codec support.
           : ALC5682I-VD/ALC5682I-VS load different hid name depending on SSFC.
           : Define SSFC BIT9-11 for codec selection.
> Please re-flow for 75 characters per line.

Done

https://review.coreboot.org/c/coreboot/+/59856/comment/2f630286_af9e219b 
PS5, Line 16: work
> works

Done

https://review.coreboot.org/c/coreboot/+/59856/comment/c0a2e849_91b87430 
PS5, Line 15: TEST=Set CBI SSFC BIT9-11 to select codec,
            :      and test audio work
> Fits it one like.

Done

File src/mainboard/google/octopus/mainboard.c:

https://review.coreboot.org/c/coreboot/+/59856/comment/3871d2c5_ad0d81a7 
PS4, Line 218: 				cfg->hid = "RTL5682";
> Originally we expect overridetree. […]

After test with patchset #6, make another object for VS in the overridetree.cb, then the VD codec never shows.

I add debug log like this:
    if ((audio_dev->chip_ops == &drivers_i2c_generic_ops) {
      printk(BIOS_INFO, "PAUL: codec = %d\n", codec);
      printk(BIOS_INFO, "PAUL: hid = %s\n", cfg->hid);
      if (SSFC_VD && hid == 10EC5682) {
          ....
      }
      if (SSFC_VS && hid == RTL5682) {
          ....
      }
    }

1. Add VS object in the overridetree.cb, coreboot log shows
```
SSFC not set in CBI
PAUL: codec = 2
PAUL: hid = RTL5682
I2C Device has been disabled
PCI:00.2: Could not disable the device
FMAP: area GBB found @ 3c0000 (262144 bytes)
```

2. Remove VS object in the overridetree.cb, coreboot log shows
```
SSFC not set in CBI
PAUL: codec = 2
PAUL: hid = 10EC5682
enable RT5682 VD.
PCI:00.2: Could not disable the device
FMAP: area GBB found @ 3c0000 (262144 bytes)
```

File src/mainboard/google/octopus/mainboard.c:

https://review.coreboot.org/c/coreboot/+/59856/comment/0ab3a69d_3a0aea17 
PS5, Line 212: 		if ((audio_dev->chip_ops == &drivers_i2c_generic_ops) &&
> Could we category it with line 195 together since they all need to be drivers_i2c_generic_ops?

Done