Attention is currently required from: Hung-Te Lin, Jarried Lin, Kenji Yu.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85516?usp=email )
Change subject: soc/mediatek/mt8196: Initialize SSPM
......................................................................
Patch Set 15: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85516/comment/6a9ef472_00f79e10?usp... :
PS15, Line 11: enable
enable it
File src/soc/mediatek/common/include/soc/sspm.h:
https://review.coreboot.org/c/coreboot/+/85516/comment/2e4ced45_44e488d1?usp... :
PS15, Line 13: void sspm_enable_sram(void);
Can we add a blank line above, and another blank line below `sspm_init`?
File src/soc/mediatek/mt8196/sspm_sram.c:
https://review.coreboot.org/c/coreboot/+/85516/comment/b1695a86_98c62523?usp... :
PS15, Line 14: (
remove
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85516?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic56f0bad2f4cbf11d5711425d57c3b5b6bf283f0
Gerrit-Change-Number: 85516
Gerrit-PatchSet: 15
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Kenji Yu
kenji.yu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Kenji Yu
kenji.yu@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 11 Dec 2024 06:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes