Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )
Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 board support ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/li... File Documentation/mainboard/libretrend/lt1000.md:
https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/li... PS13, Line 47: Fastboot
I maybe lack information about: […]
Thanks. I suggest to use *Fastboot (MRC cache)* then.
https://review.coreboot.org/c/coreboot/+/30360/13/Documentation/mainboard/li... PS13, Line 62: - speakers and mic header
Thank you Matt.
Thanks, maybe add that it works in GNU/Linux (version).
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... File src/mainboard/libretrend/lt1000/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/30360/13/src/mainboard/libretrend/l... PS13, Line 1: /*
IIRC there was a discussion some time ago about correctness of adding power button in ACPI. […]
Yes, current FWTS should complain also.
See CB:27272 for details.