Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33946
Change subject: util/inteltool: Enable -Wmissing-prototypes ......................................................................
util/inteltool: Enable -Wmissing-prototypes
Change-Id: I6bf041d089498780ea2b7c52402d7452d44d3f87 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M util/inteltool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/33946/1
diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile index d88063b..0f74a7c 100644 --- a/util/inteltool/Makefile +++ b/util/inteltool/Makefile @@ -22,7 +22,7 @@ CC ?= gcc INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local -CFLAGS ?= -O2 -g -Wall -W +CFLAGS ?= -O2 -g -Wall -W -Wmissing-prototypes LDFLAGS += -lpci -lz
CPPFLAGS += -I$(top)/src/commonlib/include
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33946 )
Change subject: util/inteltool: Enable -Wmissing-prototypes ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33946 )
Change subject: util/inteltool: Enable -Wmissing-prototypes ......................................................................
util/inteltool: Enable -Wmissing-prototypes
Change-Id: I6bf041d089498780ea2b7c52402d7452d44d3f87 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/33946 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/inteltool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile index d88063b..0f74a7c 100644 --- a/util/inteltool/Makefile +++ b/util/inteltool/Makefile @@ -22,7 +22,7 @@ CC ?= gcc INSTALL ?= /usr/bin/env install PREFIX ?= /usr/local -CFLAGS ?= -O2 -g -Wall -W +CFLAGS ?= -O2 -g -Wall -W -Wmissing-prototypes LDFLAGS += -lpci -lz
CPPFLAGS += -I$(top)/src/commonlib/include
-
HAOUAS Elyes (Code Review) -
Jacob Garber (Code Review)
-
Martin Roth (Code Review)