Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83231?usp=email )
Change subject: drivers/intel/ish: Skip ISH version call if CSE sync is done by payload ......................................................................
drivers/intel/ish: Skip ISH version call if CSE sync is done by payload
This patch skips the ISH firmware version print when CSE sync is done by payload. The payload is responsible to dump the ISH version as ISH version resides into the CSE boot partition table.
BUG=b:305898363 TEST=Able to build google/rex.
Change-Id: I1895a4d3c44838a9cc6380912f09aa4f0e6687bd Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83231 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Dinesh Gehlot digehlot@google.com Reviewed-by: Eric Lai ericllai@google.com --- M src/drivers/intel/ish/ish.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, but someone else must approve Dinesh Gehlot: Looks good to me, approved Nick Vaccaro: Looks good to me, approved
diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c index 7d332e1..1ab6a0a 100644 --- a/src/drivers/intel/ish/ish.c +++ b/src/drivers/intel/ish/ish.c @@ -50,6 +50,9 @@
static void intel_ish_get_version(void) { + if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_BY_PAYLOAD)) + return; + struct cse_specific_info *info = cbmem_find(CBMEM_ID_CSE_INFO); if (info == NULL) return;