Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Boris Mittelberg.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50084 )
Change subject: mb/google/brya: Change EC -> PCH wake pin to GPP_F17
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
looks good! Note that your patches cannot be submitted while there are still comments that are still unresolved (i.e. not marked "resolved"). FYI, there's also a policy of letting patches sit for >= 24 hours before submission, b/c coreboot is very global 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50084
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2bc5b1562ab30b4461fc7e3b1a4bc3e370db588
Gerrit-Change-Number: 50084
Gerrit-PatchSet: 2
Gerrit-Owner: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Thu, 28 Jan 2021 21:48:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment