Attention is currently required from: Patrick Rudolph, Johnny Lin, Paul Menzel, Tim Chu.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add ArcherCity CRB support ......................................................................
Patch Set 10:
(25 comments)
File src/mainboard/intel/archercity_crb/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/d9f3b8f5_53f23a77 PS10, Line 15: #define PCR_DMI_LPCIOD 0x2770 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/bdd1d9c0_2319b8b6 PS10, Line 16: #define PCR_DMI_LPCIOE 0x2774 please, no space before tabs
File src/mainboard/intel/archercity_crb/include/sprsp_ac_iio.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/410208e8_62546a62 PS10, Line 9: #define CFG_UPD_PCIE_PORT(pexphide, slotimp, slotpsp) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/9b369916_403f3a7d PS10, Line 11: .SLOTEIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/9645c65d_25543dea PS10, Line 12: .SLOTHPCAP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/9feed2ee_c754bd8a PS10, Line 13: .SLOTHPSUP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/a5874378_134a9c9f PS10, Line 14: .SLOTPIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/e59501f7_666ee511 PS10, Line 15: .SLOTAIP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/08a18dfe_c86b0ec7 PS10, Line 16: .SLOTMRLSP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/15dfdc26_60a251d8 PS10, Line 17: .SLOTPCP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/c65e099c_f5576534 PS10, Line 18: .SLOTABP = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/4308cafd_5c3236cc PS10, Line 19: .SLOTIMP = slotimp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/4c77c3b3_53ae0ba7 PS10, Line 20: .SLOTSPLS = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/a31d636a_b8f18a66 PS10, Line 21: .SLOTSPLV = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/38254129_3efc5dfd PS10, Line 22: .SLOTPSP = slotpsp, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/50b39419_4e9865e1 PS10, Line 23: .VppEnabled = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/35d56727_75f4b562 PS10, Line 24: .VppPort = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/70d9db53_6c554677 PS10, Line 25: .VppAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/d785caba_638b7963 PS10, Line 26: .MuxAddress = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/83e3b435_a5fffc3e PS10, Line 27: .ChannelID = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/aa245211_11ae739c PS10, Line 28: .PciePortEnable = 1, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/a2ca1cfc_53e028af PS10, Line 29: .PEXPHIDE = pexphide, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/b27abc99_e31c5462 PS10, Line 30: .HidePEXPMenu = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/edb6867a_58c4fda5 PS10, Line 31: .PciePortOwnership = 0, \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169840): https://review.coreboot.org/c/coreboot/+/71968/comment/fa175152_cc96ad3f PS10, Line 32: .RetimerConnectCount = 0, \ please, no space before tabs
-
build bot (Jenkins) (Code Review)