Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85651?usp=email )
Change subject: soc/mediatek/mt8196: Add disable modem power driver ......................................................................
Patch Set 3:
(3 comments)
File src/soc/mediatek/mt8196/include/soc/md_power_ctrl.h:
https://review.coreboot.org/c/coreboot/+/85651/comment/db1516a3_815a37c7?usp... : PS3, Line 9: md modem
File src/soc/mediatek/mt8196/md_power_ctrl.c:
https://review.coreboot.org/c/coreboot/+/85651/comment/22a60db4_4c9ee0db?usp... : PS3, Line 90: struct pmif *pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_1); : : /* Vsram_vosel = 0x24d, read Vsram value */ : reg = VSRAM_VOSEL; : pmif_arb->read(pmif_arb, SPMI_SLAVE_4, reg, &val); : : /* Vmodem_vosel = 0x24e, write Vmodem 0.75V */ : reg = VMODEM_VOSEL; : pmif_arb->write(pmif_arb, SPMI_SLAVE_4, reg, SPMI_SLAVE_4_750MV); : pmif_arb->read(pmif_arb, SPMI_SLAVE_4, reg, &val); Add `mt6363_write8` to `common/mt6363.c`. Call `mt6363_init_pmif_arb` and use read8/write8 APIs from mt6363 here.
https://review.coreboot.org/c/coreboot/+/85651/comment/d06a0fa3_8951e47f?usp... : PS3, Line 124: : while ((read32(&mtk_apifrbus_ao_io_reg_bus->sleep_protect_rdy_sta_1) & : MD1_PROT_STEP0_0_ACK_MASK) != MD1_PROT_STEP0_0_ACK_MASK) { : printk(BIOS_INFO, "First check: Does not get MD1_PROT_STEP0_0_ACK_MASK\n"); : retryCount++; : if (retryCount > MAX_RETRY_COUNT) { : printk(BIOS_INFO, "First check: check failed\n"); : break; : } : } use `retry` API or implement a `wait_for_state_ready` function