Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68017 )
Change subject: mb/lenovo/*/mainboard.c: Clean up includes ......................................................................
mb/lenovo/*/mainboard.c: Clean up includes
Signed-off-by: Elyes Haouas ehaouas@noos.fr Change-Id: I406f21c0c05e6af357e45e718422be94c6fd5408 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68017 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/lenovo/t410/mainboard.c M src/mainboard/lenovo/t420/mainboard.c M src/mainboard/lenovo/t420s/mainboard.c M src/mainboard/lenovo/t430/mainboard.c M src/mainboard/lenovo/t430s/mainboard.c M src/mainboard/lenovo/t520/mainboard.c M src/mainboard/lenovo/t530/mainboard.c M src/mainboard/lenovo/x131e/mainboard.c M src/mainboard/lenovo/x1_carbon_gen1/mainboard.c M src/mainboard/lenovo/x200/mainboard.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/mainboard.c M src/mainboard/lenovo/x230/mainboard.c 13 files changed, 14 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t410/mainboard.c b/src/mainboard/lenovo/t410/mainboard.c index 26a0f92..13cafba 100644 --- a/src/mainboard/lenovo/t410/mainboard.c +++ b/src/mainboard/lenovo/t410/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include "dock.h"
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/lenovo/t420/mainboard.c b/src/mainboard/lenovo/t420/mainboard.c index c8b212c..50c944e 100644 --- a/src/mainboard/lenovo/t420/mainboard.c +++ b/src/mainboard/lenovo/t420/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/lenovo/t420s/mainboard.c b/src/mainboard/lenovo/t420s/mainboard.c index c8b212c..50c944e 100644 --- a/src/mainboard/lenovo/t420s/mainboard.c +++ b/src/mainboard/lenovo/t420s/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/lenovo/t430/mainboard.c b/src/mainboard/lenovo/t430/mainboard.c index c8b212c..50c944e 100644 --- a/src/mainboard/lenovo/t430/mainboard.c +++ b/src/mainboard/lenovo/t430/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/lenovo/t430s/mainboard.c b/src/mainboard/lenovo/t430s/mainboard.c index c8b212c..50c944e 100644 --- a/src/mainboard/lenovo/t430s/mainboard.c +++ b/src/mainboard/lenovo/t430s/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/lenovo/t520/mainboard.c b/src/mainboard/lenovo/t520/mainboard.c index d5703f9..39790f2 100644 --- a/src/mainboard/lenovo/t520/mainboard.c +++ b/src/mainboard/lenovo/t520/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
/* mainboard_enable is executed as first thing after enumerate_buses(). */ diff --git a/src/mainboard/lenovo/t530/mainboard.c b/src/mainboard/lenovo/t530/mainboard.c index 33c95c2..b33e229 100644 --- a/src/mainboard/lenovo/t530/mainboard.c +++ b/src/mainboard/lenovo/t530/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
// mainboard_enable is executed as first thing after // enumerate_buses(). diff --git a/src/mainboard/lenovo/x131e/mainboard.c b/src/mainboard/lenovo/x131e/mainboard.c index c8b212c..50c944e 100644 --- a/src/mainboard/lenovo/x131e/mainboard.c +++ b/src/mainboard/lenovo/x131e/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/lenovo/x1_carbon_gen1/mainboard.c b/src/mainboard/lenovo/x1_carbon_gen1/mainboard.c index c8b212c..50c944e 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/mainboard.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/lenovo/x200/mainboard.c b/src/mainboard/lenovo/x200/mainboard.c index 0fc77d3..4b2f253 100644 --- a/src/mainboard/lenovo/x200/mainboard.c +++ b/src/mainboard/lenovo/x200/mainboard.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <drivers/intel/gma/int15.h> #include <drivers/lenovo/lenovo.h> -#include "dock.h"
static void fill_ssdt(const struct device *device) { diff --git a/src/mainboard/lenovo/x201/mainboard.c b/src/mainboard/lenovo/x201/mainboard.c index 1a306b1..951058b 100644 --- a/src/mainboard/lenovo/x201/mainboard.c +++ b/src/mainboard/lenovo/x201/mainboard.c @@ -1,10 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
+#include <acpi/acpi.h> #include <device/device.h> #include <ec/acpi/ec.h> -#include <northbridge/intel/ironlake/ironlake.h> -#include <southbridge/intel/bd82x6x/pch.h> -#include "dock.h" #include <drivers/intel/gma/int15.h> #include <drivers/lenovo/lenovo.h>
diff --git a/src/mainboard/lenovo/x220/mainboard.c b/src/mainboard/lenovo/x220/mainboard.c index 33c95c2..b33e229 100644 --- a/src/mainboard/lenovo/x220/mainboard.c +++ b/src/mainboard/lenovo/x220/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
// mainboard_enable is executed as first thing after // enumerate_buses(). diff --git a/src/mainboard/lenovo/x230/mainboard.c b/src/mainboard/lenovo/x230/mainboard.c index 33c95c2..b33e229 100644 --- a/src/mainboard/lenovo/x230/mainboard.c +++ b/src/mainboard/lenovo/x230/mainboard.c @@ -2,7 +2,6 @@
#include <device/device.h> #include <drivers/intel/gma/int15.h> -#include <ec/lenovo/h8/h8.h>
// mainboard_enable is executed as first thing after // enumerate_buses().
-
Felix Held (Code Review)