Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34394 )
Change subject: mb/esd/atom15/gpio.c: fix whitespace ......................................................................
mb/esd/atom15/gpio.c: fix whitespace
Tabs, tabs, tabs...
Change-Id: I65c0918957a571aaa6f49d884625af337fb2ad7c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/esd/atom15/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/34394/1
diff --git a/src/mainboard/esd/atom15/gpio.c b/src/mainboard/esd/atom15/gpio.c index b9c7829..bc33517 100644 --- a/src/mainboard/esd/atom15/gpio.c +++ b/src/mainboard/esd/atom15/gpio.c @@ -155,8 +155,8 @@ GPIO_NC, /* GPIO_S0_SC[089] - No Connect */ GPIO_FUNC1, /* GPIO_S0_SC[090] - EXP_I2C_SDA */ GPIO_FUNC1, /* GPIO_S0_SC[091] - EXP_I2C_SCL */ - GPIO_FUNC1, /* GPIO_S0_SC[092] - 0R GND? */ - GPIO_FUNC1, /* GPIO_S0_SC[093] - 0R GND? */ + GPIO_FUNC1, /* GPIO_S0_SC[092] - 0R GND? */ + GPIO_FUNC1, /* GPIO_S0_SC[093] - 0R GND? */ GPIO_FUNC1, /* GPIO_S0_SC[094] - SOC_PWM0 */ GPIO_FUNC1, /* GPIO_S0_SC[095] - SOC_PWM1 */ GPIO_NC, /* GPIO_S0_SC[096] - No Connect */ @@ -200,7 +200,7 @@ GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[27] - SW450-1 */ GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[28] - SW450-2 */ GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[29] - SW450-3 */ - GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[30] - SW450-4 */ + GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[30] - SW450-4 */ GPIO_NC, /* GPIO_S5[31] - No Connect */ GPIO_NC, /* GPIO_S5[32] - No Connect */ GPIO_NC, /* GPIO_S5[33] - No Connect */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34394 )
Change subject: mb/esd/atom15/gpio.c: fix whitespace ......................................................................
Patch Set 1:
Should be trivial
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34394 )
Change subject: mb/esd/atom15/gpio.c: fix whitespace ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34394 )
Change subject: mb/esd/atom15/gpio.c: fix whitespace ......................................................................
Patch Set 1: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34394 )
Change subject: mb/esd/atom15/gpio.c: fix whitespace ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34394 )
Change subject: mb/esd/atom15/gpio.c: fix whitespace ......................................................................
mb/esd/atom15/gpio.c: fix whitespace
Tabs, tabs, tabs...
Change-Id: I65c0918957a571aaa6f49d884625af337fb2ad7c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34394 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/esd/atom15/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/src/mainboard/esd/atom15/gpio.c b/src/mainboard/esd/atom15/gpio.c index b9c7829..bc33517 100644 --- a/src/mainboard/esd/atom15/gpio.c +++ b/src/mainboard/esd/atom15/gpio.c @@ -155,8 +155,8 @@ GPIO_NC, /* GPIO_S0_SC[089] - No Connect */ GPIO_FUNC1, /* GPIO_S0_SC[090] - EXP_I2C_SDA */ GPIO_FUNC1, /* GPIO_S0_SC[091] - EXP_I2C_SCL */ - GPIO_FUNC1, /* GPIO_S0_SC[092] - 0R GND? */ - GPIO_FUNC1, /* GPIO_S0_SC[093] - 0R GND? */ + GPIO_FUNC1, /* GPIO_S0_SC[092] - 0R GND? */ + GPIO_FUNC1, /* GPIO_S0_SC[093] - 0R GND? */ GPIO_FUNC1, /* GPIO_S0_SC[094] - SOC_PWM0 */ GPIO_FUNC1, /* GPIO_S0_SC[095] - SOC_PWM1 */ GPIO_NC, /* GPIO_S0_SC[096] - No Connect */ @@ -200,7 +200,7 @@ GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[27] - SW450-1 */ GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[28] - SW450-2 */ GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[29] - SW450-3 */ - GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[30] - SW450-4 */ + GPIO_FUNC(0, PULL_DISABLE, 10K), /* GPIO_S5[30] - SW450-4 */ GPIO_NC, /* GPIO_S5[31] - No Connect */ GPIO_NC, /* GPIO_S5[32] - No Connect */ GPIO_NC, /* GPIO_S5[33] - No Connect */
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)