Attention is currently required from: Felix Held, Fred Reitberger, Martin Roth, Nikolai Vyssotski, Paul Menzel.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81887?usp=email )
Change subject: soc/amd/glinda: Add support for A0 and B0 steppings
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81887/comment/94c575ab_bfbabe6d :
PS2, Line 7: soc/amd/glinda :
Please remove the space before the colon.
Done
https://review.coreboot.org/c/coreboot/+/81887/comment/241435df_622fcd24 :
PS2, Line 9: Update the A0 and B0 stepping IDs in CPU table
Please mention the datasheet name and revision.
Done
File src/soc/amd/glinda/include/soc/cpu.h:
https://review.coreboot.org/c/coreboot/+/81887/comment/4b96c6ca_bf769f4d :
PS2, Line 6: 0x1A
Lowercase?
Done
https://review.coreboot.org/c/coreboot/+/81887/comment/e6c7eace_3eab5a69 :
PS2, Line 6:
Use tabs?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81887?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0072f25f981ac7d5df2522594c8788bfabcbf24c
Gerrit-Change-Number: 81887
Gerrit-PatchSet: 3
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 18 Apr 2024 08:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment