Attention is currently required from: Arthur Heymans, Felix Singer, Jakub Czapiga, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email )
Change subject: Makefiles: Rename top-level Makefiles from .inc to .mk
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Patchset:
PS3:
Vim picks up .mk fine. Cloc too (but not .mak). First Google hit suggests
.mak is a Microsoft thing?
File Makefile:
https://review.coreboot.org/c/coreboot/+/80063/comment/0ce07545_eb4d8afb :
PS3, Line 299: # TODO: Remove Makefile.inc support
This won't be easy, the pattern already spread to other projects.
I'd say we should just stay backwards compatible?
https://review.coreboot.org/c/coreboot/+/80063/comment/093e8a19_6c3524ff :
PS3, Line 306: $(eval $(call includemakefiles,$(dir)/Makefile.inc))) \
Just walking $(cursubdirs) once and calling includemakefiles twice
would work too, I guess.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80063?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9
Gerrit-Change-Number: 80063
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 21 Jan 2024 11:22:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment