Change in coreboot[master]: Mic_Bias voltage changed to 2.9V for Earpods Mic

List overview All Threads
Download

newer

older

[XL] Change in coreboot[master]:...

[S] Change in coreboot[master]:...

Vani Ganji (Code Review)

11 Oct 2019 11 Oct '19

3:53 a.m.

Vani Ganji has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35961 )

Change subject: Mic_Bias voltage changed to 2.9V for Earpods Mic ......................................................................

Mic_Bias voltage changed to 2.9V for Earpods Mic

Earpods Mic is not working with 2.6Volts and it requires a volatge greater than 2.7Volts.

BUG=b:134361881

Change-Id: Iceb62d4940a1d93404dc3f69884c1289f462f587 Signed-off-by: Vani Ganji vani.ganji@intel.com --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/35961/1

diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index ac86e79..b42313f 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -347,7 +347,7 @@ register "c_mic_btn_thr" = "0x3e" register "btn_avg" = "4" register "adc_1bit_rpt" = "1" - register "micbias_lvl" = "2600" + register "micbias_lvl" = "2900" register "mic_amp_in_sel" = ""diff"" device i2c 1a on end end

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Aamir Bohra (Code Review)

11 Oct 11 Oct

10:08 a.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35961 )

Change subject: Mic_Bias voltage changed to 2.9V for Earpods Mic ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35961/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35961/1//COMMIT_MSG@7 PS1, Line 7: Mic_Bias voltage changed to 2.9V for Earpods Mic mb/google/poppy: Change mic_bias voltage to 2.9V for atlas

-- To view, visit https://review.coreboot.org/c/coreboot/+/35961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceb62d4940a1d93404dc3f69884c1289f462f587 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 1 Gerrit-Owner: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Sathya Prakash M R sathya.prakash.m.r@intel.com Gerrit-Reviewer: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 11 Oct 2019 10:08:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Vani Ganji (Code Review)

11 a.m.

New subject: Change in coreboot[master]: mb/google/poppy: Change mic_bias voltage to 2.9V for atlas

Hello Sathya Prakash M R, Aamir Bohra, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35961

to look at the new patch set (#2).

Change subject: mb/google/poppy: Change mic_bias voltage to 2.9V for atlas ......................................................................

mb/google/poppy: Change mic_bias voltage to 2.9V for atlas

Earpods Mic is not working with 2.6Volts and it requires a volatge greater than 2.7Volts.

BUG=b:134361881

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/35961/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceb62d4940a1d93404dc3f69884c1289f462f587 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 2 Gerrit-Owner: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Sathya Prakash M R sathya.prakash.m.r@intel.com Gerrit-Reviewer: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Vani Ganji (Code Review)

11:02 a.m.

New subject: Change in coreboot[master]: mb/google/poppy: Change mic_bias voltage to 2.9V for atlas

Vani Ganji has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35961 )

Change subject: mb/google/poppy: Change mic_bias voltage to 2.9V for atlas ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35961/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35961/1//COMMIT_MSG@7 PS1, Line 7: Mic_Bias voltage changed to 2.9V for Earpods Mic

...

mb/google/poppy: Change mic_bias voltage to 2. […]

Thank you, commit message updated.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceb62d4940a1d93404dc3f69884c1289f462f587 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 2 Gerrit-Owner: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Sathya Prakash M R sathya.prakash.m.r@intel.com Gerrit-Reviewer: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 11 Oct 2019 11:02:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:13 a.m.

New subject: Change in coreboot[master]: mb/google/poppy: Change mic_bias voltage to 2.9V for atlas

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35961 )

Change subject: mb/google/poppy: Change mic_bias voltage to 2.9V for atlas ......................................................................

Patch Set 2:

(5 comments)

https://review.coreboot.org/c/coreboot/+/35961/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35961/2//COMMIT_MSG@7 PS2, Line 7: Change Increase

https://review.coreboot.org/c/coreboot/+/35961/2//COMMIT_MSG@9 PS2, Line 9: 2.6Volts Please add a space before the unit.

https://review.coreboot.org/c/coreboot/+/35961/2//COMMIT_MSG@10 PS2, Line 10: 2.7Volts Does the datasheet claim that?

So why do you choose 2.9 V?

https://review.coreboot.org/c/coreboot/+/35961/2//COMMIT_MSG@10 PS2, Line 10: volatge voltage

https://review.coreboot.org/c/coreboot/+/35961/2//COMMIT_MSG@9 PS2, Line 9: Earpods Mic is not working with 2.6Volts and it requires : a volatge greater than 2.7Volts. Please use the full text width of 75 characters.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35961 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceb62d4940a1d93404dc3f69884c1289f462f587 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 2 Gerrit-Owner: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Sathya Prakash M R sathya.prakash.m.r@intel.com Gerrit-Reviewer: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 11 Oct 2019 11:13:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

8:07 p.m.

New subject: [XS] Change in coreboot[master]: mb/google/poppy: Change mic_bias voltage to 2.9V for atlas

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35961?usp=email )

Change subject: mb/google/poppy: Change mic_bias voltage to 2.9V for atlas ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iceb62d4940a1d93404dc3f69884c1289f462f587 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 2 Gerrit-Owner: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: Aamir Bohra aamirbohra@google.com Gerrit-Reviewer: Sathya Prakash M R sathya.prakash.m.r@intel.com Gerrit-Reviewer: Vani Ganji vani.ganji@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

286

days inactive

1682

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Aamir Bohra (Code Review)
Martin L Roth (Code Review)
Paul Menzel (Code Review)
Vani Ganji (Code Review)