[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ......................................................................
Patch Set 12:
(3 comments)
File src/ec/clevo/it5570e/i2ec.h:
https://review.coreboot.org/c/coreboot/+/68791/comment/a470aac2_2bbaea2e PS4, Line 10: #define D2ADR 0x2e
that's what the comment on line 13 tried to do ;) I'll make it clearer
hopefully clearer now
File src/ec/clevo/it5570e/i2ec.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/bd1bc022_95319314 PS4, Line 11: 0x2e
OK, so it's not the same thing. […]
reworked and successfully tested (by setting the cmos option for the keyboard backlight boot effect to enable/disable and read the ec register through the debugger interface).
I decided to hardcode the PNP device, since no Clevo board uses 0x4e/0x4f anyways
File src/ec/clevo/it5570e/i2ec.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/c892e80e_a1df6385 PS12, Line 17: I2EC_ADDR_H
good catch. I'm completely confused now... I had tested the backlight effect switch and it worked... […]
Done
-
Michael Niewöhner (Code Review)