HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43945 )
Change subject: src/soc/rockchip: Add missing <{stddef,stdint}.h> ......................................................................
src/soc/rockchip: Add missing <{stddef,stdint}.h>
Change-Id: I0b7bdd9f46846bc9c3d9672b50dfe2fb166fcb78 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/rockchip/common/i2c.c M src/soc/rockchip/rk3399/spi_bitbang.c 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43945/1
diff --git a/src/soc/rockchip/common/i2c.c b/src/soc/rockchip/common/i2c.c index 393b457..dbbfd3e 100644 --- a/src/soc/rockchip/common/i2c.c +++ b/src/soc/rockchip/common/i2c.c @@ -10,6 +10,8 @@ #include <soc/soc.h> #include <soc/i2c.h> #include <soc/clock.h> +#include <stddef.h> +#include <stdint.h>
#define RETRY_COUNT 3 /* 100000us = 100ms */ diff --git a/src/soc/rockchip/rk3399/spi_bitbang.c b/src/soc/rockchip/rk3399/spi_bitbang.c index 6bb854d..27b23f1 100644 --- a/src/soc/rockchip/rk3399/spi_bitbang.c +++ b/src/soc/rockchip/rk3399/spi_bitbang.c @@ -8,6 +8,7 @@ #include <soc/spi.h> #include <spi_bitbang.h> #include <spi_flash.h> +#include <stddef.h>
struct rockchip_bitbang_slave { struct spi_bitbang_ops ops;
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43945 )
Change subject: src/soc/rockchip: Add missing <{stddef,stdint}.h> ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43945 )
Change subject: src/soc/rockchip: Add missing <{stddef,stdint}.h> ......................................................................
src/soc/rockchip: Add missing <{stddef,stdint}.h>
Change-Id: I0b7bdd9f46846bc9c3d9672b50dfe2fb166fcb78 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43945 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/soc/rockchip/common/i2c.c M src/soc/rockchip/rk3399/spi_bitbang.c 2 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/soc/rockchip/common/i2c.c b/src/soc/rockchip/common/i2c.c index 393b457..dbbfd3e 100644 --- a/src/soc/rockchip/common/i2c.c +++ b/src/soc/rockchip/common/i2c.c @@ -10,6 +10,8 @@ #include <soc/soc.h> #include <soc/i2c.h> #include <soc/clock.h> +#include <stddef.h> +#include <stdint.h>
#define RETRY_COUNT 3 /* 100000us = 100ms */ diff --git a/src/soc/rockchip/rk3399/spi_bitbang.c b/src/soc/rockchip/rk3399/spi_bitbang.c index 6bb854d..27b23f1 100644 --- a/src/soc/rockchip/rk3399/spi_bitbang.c +++ b/src/soc/rockchip/rk3399/spi_bitbang.c @@ -8,6 +8,7 @@ #include <soc/spi.h> #include <spi_bitbang.h> #include <spi_flash.h> +#include <stddef.h>
struct rockchip_bitbang_slave { struct spi_bitbang_ops ops;
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)