Attention is currently required from: Michał Żygowski, Michał Kopeć, Arthur Heymans.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66266 )
Change subject: mb/intel/adlrvp: Fix expected statement
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS2:
so, " case ADL_P_LP5_1: […]
I mean, the default statement will execute "return" before ADL_P_LP5_{1,2}
default:
return; /* here , cases ADL_P_LP5_{1,2} are ignored */
case ADL_P_LP5_1:
case ADL_P_LP5_2:
mem_cfg->Lp5BankMode = 1;
return;
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66266
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a5d39bb3cbde64f82fc90186b0f2fb64bcde595
Gerrit-Change-Number: 66266
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 06 Nov 2022 10:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment