Attention is currently required from: Zhuohao Lee.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52754 )
Change subject: mb/google/brya: select GOOGLE_SMBIOS_MAINBOARD_VERSION
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52754/comment/8f93aded_c760542d
PS1, Line 9: In order to use the function smbios_mainboard_version()
: to query the board revision from the EC.
: we need to select GOOGLE_SMBIOS_MAINBOARD_VERSION.
suggestion: selectin GOOGLE_SMBIOS_MAINBOARD_VERSION allows querying board revision from the EC.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8eeb958f73607afb801794f91fbf91ec7bd5cd8b
Gerrit-Change-Number: 52754
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Thu, 29 Apr 2021 16:17:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment