[M] Change in coreboot[main]: autoport: Factor out GPIO config generation - coreboot-gerrit

5 Jul 2024


      Attention is currently required from: Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File util/autoport/gpio_common.go:
https://review.coreboot.org/c/coreboot/+/83286/comment/7fa8e16e_4b1f0111?usp... :
PS1, Line 10: func writeGPIOSet(ctx Context, sb *os.File,
Can't say that I know the language. Is there a way to make this not
part of the global scope?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes