Attention is currently required from: Jakub Czapiga, Julius Werner, Simon Glass, Subrata Banik.
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73150?usp=email )
Change subject: libpayload/libcbfs: Support file type in unverified_area APIs
......................................................................
Patch Set 5:
(1 comment)
File payloads/libpayload/include/cbfs.h:
https://review.coreboot.org/c/coreboot/+/73150/comment/9ffd69aa_ba25adb6 :
PS4, Line 27: static inline void *cbfs_unverified_area_type_map(const char *area, const char *name,
I meant we shouldn't add any of this to libpayload. […]
OK, so just drop all the code in payloads/ ?
Is it still possible to add a test? Why is the code duplicated in two places?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73150?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I286addab7c435a47e5d22161be84e9fc559de4b9
Gerrit-Change-Number: 73150
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Simon Glass
sjg@chromium.org
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 01 Aug 2023 21:55:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Simon Glass
sjg@chromium.org
Gerrit-MessageType: comment