Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61528 )
Change subject: mb/intel/adlrvp: Fix vbt loading error ......................................................................
mb/intel/adlrvp: Fix vbt loading error
When booting ADL RVP, coreboot is unable to load VBT binary as makefile will rename VBT binary to "vbt.bin" when building coreboot.rom.
The reason for having this function is that chromeOS has emerge tool to streamline the VBT stitching process to support multiple VBTs for different RVP boards; while we only need 1 vbt for generic non-chromeOS usage. Hence add a chomeos kconfig to guard this.
TEST=Able to boot ADL RVP DDR5 with DP display.
Signed-off-by: Lean Sheng Tan sheng.tan@9elements.com Change-Id: I5f6f9554b75f4d62198aac9938e65c71c3e7cee9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61528 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/intel/adlrvp/mainboard.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Maulik V Vaghela: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index f929b10..d988fac 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -68,6 +68,9 @@
const char *mainboard_vbt_filename(void) { + if (!CONFIG(CHROMEOS)) + return "vbt.bin"; + uint8_t sku_id = get_board_id(); switch (sku_id) { case ADL_P_LP5_1: