HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36261 )
Change subject: soc/intel/apollolake/acpi: Drop wrong _ADR objects for gpio ......................................................................
soc/intel/apollolake/acpi: Drop wrong _ADR objects for gpio
Use a _HID but not _HID and _ADR at the same time.
Found-by: ACPICA 20191018 Change-Id: I9f55cc033b5672917520b139444bc614462c4a05 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/apollolake/acpi/gpio.asl 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/36261/1
diff --git a/src/soc/intel/apollolake/acpi/gpio.asl b/src/soc/intel/apollolake/acpi/gpio.asl index b9a2cf1..de556e0 100644 --- a/src/soc/intel/apollolake/acpi/gpio.asl +++ b/src/soc/intel/apollolake/acpi/gpio.asl @@ -23,7 +23,6 @@
Device (GPO0) { - Name (_ADR, 0) Name (_HID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME) Name (_DDN, GPIO_COMM_0_DESC) @@ -54,7 +53,6 @@
Device (GPO1) { - Name (_ADR, 0) Name (_HID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME) Name (_DDN, GPIO_COMM_1_DESC) @@ -85,7 +83,6 @@
Device (GPO2) { - Name (_ADR, 0) Name (_HID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME) Name (_DDN, GPIO_COMM_2_DESC) @@ -116,7 +113,6 @@
Device (GPO3) { - Name (_ADR, 0) Name (_HID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME) Name (_DDN, GPIO_COMM_3_DESC)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36261 )
Change subject: soc/intel/apollolake/acpi: Drop wrong _ADR objects for gpio ......................................................................
Patch Set 2: Code-Review+2
Hello Patrick Rudolph, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36261
to look at the new patch set (#3).
Change subject: soc/intel/apollolake/acpi: Drop wrong _ADR objects for gpio ......................................................................
soc/intel/apollolake/acpi: Drop wrong _ADR objects for gpio
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Found-by: ACPICA 20191018 Change-Id: I9f55cc033b5672917520b139444bc614462c4a05 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/apollolake/acpi/gpio.asl 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/36261/3
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36261 )
Change subject: soc/intel/apollolake/acpi: Drop wrong _ADR objects for gpio ......................................................................
soc/intel/apollolake/acpi: Drop wrong _ADR objects for gpio
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."
Found-by: ACPICA 20191018 Change-Id: I9f55cc033b5672917520b139444bc614462c4a05 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36261 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/apollolake/acpi/gpio.asl 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/apollolake/acpi/gpio.asl b/src/soc/intel/apollolake/acpi/gpio.asl index b9a2cf1..de556e0 100644 --- a/src/soc/intel/apollolake/acpi/gpio.asl +++ b/src/soc/intel/apollolake/acpi/gpio.asl @@ -23,7 +23,6 @@
Device (GPO0) { - Name (_ADR, 0) Name (_HID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME) Name (_DDN, GPIO_COMM_0_DESC) @@ -54,7 +53,6 @@
Device (GPO1) { - Name (_ADR, 0) Name (_HID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME) Name (_DDN, GPIO_COMM_1_DESC) @@ -85,7 +83,6 @@
Device (GPO2) { - Name (_ADR, 0) Name (_HID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME) Name (_DDN, GPIO_COMM_2_DESC) @@ -116,7 +113,6 @@
Device (GPO3) { - Name (_ADR, 0) Name (_HID, GPIO_COMM_NAME) Name (_CID, GPIO_COMM_NAME) Name (_DDN, GPIO_COMM_3_DESC)
-
Furquan Shaikh (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)