Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40027 )
Change subject: mb/google/puff: Fix up WLAN_OFF gpio configuration ......................................................................
mb/google/puff: Fix up WLAN_OFF gpio configuration
BUG=b:152927525 BRANCH=none TEST=builds
Change-Id: I691377624c870eb0fc6f7e84a4b9cd50b7b09654 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/puff/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/40027/1
diff --git a/src/mainboard/google/hatch/variants/puff/gpio.c b/src/mainboard/google/hatch/variants/puff/gpio.c index d1465fe..362900d 100644 --- a/src/mainboard/google/hatch/variants/puff/gpio.c +++ b/src/mainboard/google/hatch/variants/puff/gpio.c @@ -39,6 +39,8 @@ PAD_CFG_GPO(GPP_C10, 1, DEEP), /* C11 : PCH_PCON_PDB_ODL */ PAD_CFG_GPO(GPP_C11, 1, DEEP), + /* C15 : WLAN_OFF_L */ + PAD_CFG_GPO(GPP_C15, 1, DEEP),
/* E2 : EN_PP_MST_OD */ PAD_CFG_GPO(GPP_E2, 1, DEEP),
Tim Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40027 )
Change subject: mb/google/puff: Fix up WLAN_OFF gpio configuration ......................................................................
Patch Set 1: Code-Review+1
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40027 )
Change subject: mb/google/puff: Fix up WLAN_OFF gpio configuration ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40027 )
Change subject: mb/google/puff: Fix up WLAN_OFF gpio configuration ......................................................................
mb/google/puff: Fix up WLAN_OFF gpio configuration
BUG=b:152927525 BRANCH=none TEST=builds
Change-Id: I691377624c870eb0fc6f7e84a4b9cd50b7b09654 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40027 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Chen tim-chen@quanta.corp-partner.google.com Reviewed-by: Daniel Kurtz djkurtz@google.com --- M src/mainboard/google/hatch/variants/puff/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Chen: Looks good to me, but someone else must approve Daniel Kurtz: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/puff/gpio.c b/src/mainboard/google/hatch/variants/puff/gpio.c index 8e4f170..60842a4 100644 --- a/src/mainboard/google/hatch/variants/puff/gpio.c +++ b/src/mainboard/google/hatch/variants/puff/gpio.c @@ -28,6 +28,8 @@ PAD_CFG_GPO(GPP_C10, 1, DEEP), /* C11 : PCH_PCON_PDB_ODL */ PAD_CFG_GPO(GPP_C11, 1, DEEP), + /* C15 : WLAN_OFF_L */ + PAD_CFG_GPO(GPP_C15, 1, DEEP),
/* E2 : EN_PP_MST_OD */ PAD_CFG_GPO(GPP_E2, 1, DEEP),
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40027 )
Change subject: mb/google/puff: Fix up WLAN_OFF gpio configuration ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2330 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2329 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2328
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Daniel Kurtz (Code Review)
-
Edward O'Callaghan (Code Review)
-
Tim Chen (Code Review)