Attention is currently required from: Tarun Tuli, Paul Menzel.
Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68305 )
Change subject: soc/intel: Add Meteor Lake IGD device id 0x7d45 ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68305/comment/262a7329_9f907358 PS2, Line 7: src/soc/intel/{common,meteorlake}: Add new Meteor Lake device ID
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/68305/comment/e5b2f2b1_234c2cf1 PS2, Line 7: src/
Please remove.
Done
https://review.coreboot.org/c/coreboot/+/68305/comment/fd5aeada_2701686d PS2, Line 10:
Was this id missed in the past? Anyway, just add: Reorder the macros, so the smallest id comes first […]
Macros are based of def which are sorted in ascending order #define PCI_DID_INTEL_MTL_P_GT2_1 0x7d45 #define PCI_DID_INTEL_MTL_P_GT2_2 0x7d50 #define PCI_DID_INTEL_MTL_P_GT2_3 0x7d55 #define PCI_DID_INTEL_MTL_P_GT2_4 0x7d60
-
Ravishankar Sarawadi (Code Review)