Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP ......................................................................
mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
With current setting Display audio codec probe fails. Hence HDMI/DP audio fails.
Earlier, with FSP 2037 was used the mode was incorrectly programmed to 4T
This setting was carried ahead with below change: Commit : 50f8b4ebdd7db8077b87ab7686637599c9d93af3
The issue was fixed in later FSPs and with current FSP v2237, we need to set the TMODE to 8T as per spec.
TEST=Verify HDMI/DP Playback on ADL P RVP
Fixes: 50f8b4ebdd7db8077b87ab7686637599c9d93af3 (soc/intel/alderlake: Add enum for HDA audio configuration)
Signed-off-by: Sathya Prakash M R sathya.prakash.m.r@intel.com Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56208 Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Balaji Manigandan balaji.manigandan@intel.com Reviewed-by: Meera Ravindranath meera.ravindranath@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/adlrvp/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Balaji Manigandan: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved Sathya Prakash M R: Looks good to me, but someone else must approve Meera Ravindranath: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/adlrvp/devicetree.cb b/src/mainboard/intel/adlrvp/devicetree.cb index d4a2eb7..c9d7da6 100644 --- a/src/mainboard/intel/adlrvp/devicetree.cb +++ b/src/mainboard/intel/adlrvp/devicetree.cb @@ -169,7 +169,7 @@
# HD Audio register "PchHdaDspEnable" = "1" - register "PchHdaIDispLinkTmode" = "HDA_TMODE_4T" + register "PchHdaIDispLinkTmode" = "HDA_TMODE_8T" register "PchHdaIDispLinkFrequency" = "HDA_LINKFREQ_96MHZ" register "PchHdaIDispCodecEnable" = "1"