Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro.
Amanda Hwang has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/82717?usp=email )
Change subject: mb/google/trulo/var/orisa: Configure TPM IRQ for orisa
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/82717/comment/84ebb333_2e15b792?usp... :
PS1, Line 690: default 13 if !BOARD_GOOGLE_BASEBOARD_HADES && !BOARD_GOOGLE_ORISA # GPE0_DW0_13 (GPP_A13_IRQ)
Wondering if change the order can help or not? Does Kconfig return the first match?
Yes, it looks like Kconfig does indeed return the first match.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82717?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I065fdf2a66036c6df1e16dda3b2a684b5202cccc
Gerrit-Change-Number: 82717
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 03 Jun 2024 05:35:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com