Attention is currently required from: Paul Menzel, HAOUAS Elyes. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59880 )
Change subject: Makefile.inc: Ignore IASL's "Missing dependency" warning ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Thanks! Much appreciated as always.
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59880/comment/fbe47e50_3ef89897 PS1, Line 278: CONFIG_BOARD_ACER_G43T_AM3 Instead of doing it this way, maybe add a IGNORE_IASL_MISSING_DEPENDENCY to each of the boards' kconfigs. Then we can check for that here and add the ignore.
We can also use the build_complete:: target to add the warning so that it appears at the end of the build:
ifeq ($(CONFIG_IGNORE_IASL_MISSING_DEPENDENCY),y) build_complete:: echo "*** WARNING: The ASL code for this platform is incomplete. Please fix it. ***" echo "*** If _PRS is present, must have _CRS and _SRS ***" echo "*** If _SRS is present, must have _PRS, _CRS, and _SRS ***" echo "*** If _DIS is present, must have _SRS, _PRS, _CRS, and _SRS ***" endif
-
Martin Roth (Code Review)