Change in coreboot[master]: payloads: FILO: Hook up autoboot options - coreboot-gerrit

12 Jul 2021


      Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 )
Change subject: payloads: FILO: Hook up autoboot options
......................................................................
Patch Set 1:
(2 comments)
File payloads/external/FILO/Makefile:
https://review.coreboot.org/c/coreboot/+/56213/comment/9e106384_b354732a 
PS1, Line 36: ifeq ($(CONFIG_FILO_USE_AUTOBOOT),y)
...
For some reason, even if selected, the if is not chosen.
You stripped the `FILO_` when passing it to the inner Makefile.
https://review.coreboot.org/c/coreboot/+/56213/comment/d9524daf_45408205 
PS1, Line 39: FILO_
Same here.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a
Gerrit-Change-Number: 56213
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC:  Felix Singer felixsinger@posteo.net
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Mon, 12 Jul 2021 16:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment