Change in coreboot[master]: nb/amd/agesa/family14/northbridge.c: Report missing resources - coreboot-gerrit

10 Apr 2022


      Attention is currently required from: Nico Huber, Michał Żygowski, Michał Kopeć, Angel Pons, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52935 )
Change subject: nb/amd/agesa/family14/northbridge.c: Report missing resources
......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52935/comment/58eb2507_f3229f4c 
PS9, Line 9: Not all resources were being reported, add them.
Which ones exactly?
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52935/comment/b2f630e4_d1ff8241 
PS9, Line 115: 	/* Reserve everything between A segment and 1MB:
Please use:
/*
     * […]
     */
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b1b5f585ff6e0c7aecad250a75600e0c76331e1
Gerrit-Change-Number: 52935
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 10 Apr 2022 05:22:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment