Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76132?usp=email )
Change subject: acpi: Add functions to declare ARM GIC V3 hardware ......................................................................
Patch Set 5:
(2 comments)
File src/arch/arm64/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76132/comment/17e19521_689a091c : PS5, Line 122: ramstage-$(CONFIG_ACPI_COMMON_MADT_GICC_V3) += ../../acpi/acpi_gic.c Why put that here and not in acpi/Makefile.inc?
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/76132/comment/4c95182d_92a110c9 : PS5, Line 1571: uintptr_t get_gicr_base(void); These are platform callbacks, right? They should probably be a bit better namespaced, e.g. how about platform_get_gicd_base()?