HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39075 )
Change subject: util: Remove old refrence to ROMCC ......................................................................
util: Remove old refrence to ROMCC
Change-Id: Ia1a37db8341281102ae8ae9c03f1ce76d8d126eb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/README.md M util/lint/check_lint_tests M util/lint/lint-000-license-headers M util/lint/lint-014-qualified-types M util/lint/lint-extended-015-final-newlines 5 files changed, 3 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39075/1
diff --git a/util/README.md b/util/README.md index 55bcaab..66438a9 100644 --- a/util/README.md +++ b/util/README.md @@ -86,8 +86,6 @@ * _sifive-gpt.py_ - Wraps the bootblock in a GPT partition for SiFive's bootrom. `Python3` * __rockchip__ - Generate Rockchip idblock bootloader. `Python2` -* __romcc__ - Compile a C source file generating a binary that does not -implicitly use RAM. `C` * __sconfig__ - coreboot device tree compiler `Lex` `Yacc` * __scripts__ * _config_ - Manipulate options in a .config file from the diff --git a/util/lint/check_lint_tests b/util/lint/check_lint_tests index 658fac4..766debb 100755 --- a/util/lint/check_lint_tests +++ b/util/lint/check_lint_tests @@ -30,7 +30,7 @@ git add ${TESTFILE009}
#lint-stable-010-asm-syntax -TESTFILE010=src/arch/x86/bootblock_romcc.S +TESTFILE010=src/arch/x86/bootblock_crt0.S sed -i "1s/^/.att${UNDERSCORE}syntax noprefix\n/" ${TESTFILE010} git add ${TESTFILE010}
diff --git a/util/lint/lint-000-license-headers b/util/lint/lint-000-license-headers index 88e15ec..48f7b40 100755 --- a/util/lint/lint-000-license-headers +++ b/util/lint/lint-000-license-headers @@ -24,8 +24,6 @@ ^util/amdtools/example_input/|\ ^util/cbfstool/lzma/|\ ^util/kconfig/|\ -^util/romcc/tests|\ -^util/romcc/results|\ Kconfig|\ <COPYING>|\ <LICENSE>|\ diff --git a/util/lint/lint-014-qualified-types b/util/lint/lint-014-qualified-types index 98679ea..d447c4b 100755 --- a/util/lint/lint-014-qualified-types +++ b/util/lint/lint-014-qualified-types @@ -17,7 +17,7 @@ LC_ALL=C export LC_ALL
INCLUDED_DIRS='^src/|^util/|payloads/libpayload|payloads/coreinfo' -EXCLUDED_DIRS='^src/vendorcode|^util/romcc|cbfstool/lzma|cbfstool/lz4' +EXCLUDED_DIRS='^src/vendorcode|cbfstool/lzma|cbfstool/lz4' INCLUDED_FILES='.[ch]:'
# Use git grep if the code is in a git repo, otherwise use grep. diff --git a/util/lint/lint-extended-015-final-newlines b/util/lint/lint-extended-015-final-newlines index b5a503f..ee573f5 100755 --- a/util/lint/lint-extended-015-final-newlines +++ b/util/lint/lint-extended-015-final-newlines @@ -18,7 +18,7 @@
PIDS="" INCLUDED_DIRS_AND_FILES='util/* src/* payloads/* configs/* Makefile *.inc' -EXCLUDED_DIRS='src/vendorcode/|util/romcc/|cbfstool/lzma/|cbfstool/lz4/|Documentation/|build/|3rdparty/|.git/|coreboot-builds/|util/nvidia/cbootimage/' +EXCLUDED_DIRS='src/vendorcode/|cbfstool/lzma/|cbfstool/lz4/|Documentation/|build/|3rdparty/|.git/|coreboot-builds/|util/nvidia/cbootimage/' EXCLUDED_FILES='.jpg$|.cksum$|.bin$|.vbt$|.hex$|.ico$|.o$|.bz2$|.xz$|^.tmpconfig|.pyc$|_shipped$|sha256$|.png$|.patch$'
# Use git ls-files if the code is in a git repo, otherwise use find.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39075
to look at the new patch set (#2).
Change subject: util: Remove old reference to ROMCC ......................................................................
util: Remove old reference to ROMCC
Change-Id: Ia1a37db8341281102ae8ae9c03f1ce76d8d126eb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/README.md M util/lint/check_lint_tests M util/lint/lint-000-license-headers M util/lint/lint-014-qualified-types M util/lint/lint-extended-015-final-newlines 5 files changed, 3 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39075/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39075 )
Change subject: util: Remove old reference to ROMCC ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39075 )
Change subject: util: Remove old reference to ROMCC ......................................................................
util: Remove old reference to ROMCC
Change-Id: Ia1a37db8341281102ae8ae9c03f1ce76d8d126eb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/39075 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/README.md M util/lint/check_lint_tests M util/lint/lint-000-license-headers M util/lint/lint-014-qualified-types M util/lint/lint-extended-015-final-newlines 5 files changed, 3 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/util/README.md b/util/README.md index 55bcaab..66438a9 100644 --- a/util/README.md +++ b/util/README.md @@ -86,8 +86,6 @@ * _sifive-gpt.py_ - Wraps the bootblock in a GPT partition for SiFive's bootrom. `Python3` * __rockchip__ - Generate Rockchip idblock bootloader. `Python2` -* __romcc__ - Compile a C source file generating a binary that does not -implicitly use RAM. `C` * __sconfig__ - coreboot device tree compiler `Lex` `Yacc` * __scripts__ * _config_ - Manipulate options in a .config file from the diff --git a/util/lint/check_lint_tests b/util/lint/check_lint_tests index 6b1860f..6f6942d 100755 --- a/util/lint/check_lint_tests +++ b/util/lint/check_lint_tests @@ -36,7 +36,7 @@ git add ${TESTFILE009}
#lint-stable-010-asm-syntax -TESTFILE010=src/arch/x86/bootblock_romcc.S +TESTFILE010=src/arch/x86/bootblock_crt0.S sed -i "1s/^/.att${UNDERSCORE}syntax noprefix\n/" ${TESTFILE010} git add ${TESTFILE010}
diff --git a/util/lint/lint-000-license-headers b/util/lint/lint-000-license-headers index 88e15ec..48f7b40 100755 --- a/util/lint/lint-000-license-headers +++ b/util/lint/lint-000-license-headers @@ -24,8 +24,6 @@ ^util/amdtools/example_input/|\ ^util/cbfstool/lzma/|\ ^util/kconfig/|\ -^util/romcc/tests|\ -^util/romcc/results|\ Kconfig|\ <COPYING>|\ <LICENSE>|\ diff --git a/util/lint/lint-014-qualified-types b/util/lint/lint-014-qualified-types index 98679ea..d447c4b 100755 --- a/util/lint/lint-014-qualified-types +++ b/util/lint/lint-014-qualified-types @@ -17,7 +17,7 @@ LC_ALL=C export LC_ALL
INCLUDED_DIRS='^src/|^util/|payloads/libpayload|payloads/coreinfo' -EXCLUDED_DIRS='^src/vendorcode|^util/romcc|cbfstool/lzma|cbfstool/lz4' +EXCLUDED_DIRS='^src/vendorcode|cbfstool/lzma|cbfstool/lz4' INCLUDED_FILES='.[ch]:'
# Use git grep if the code is in a git repo, otherwise use grep. diff --git a/util/lint/lint-extended-015-final-newlines b/util/lint/lint-extended-015-final-newlines index b5a503f..ee573f5 100755 --- a/util/lint/lint-extended-015-final-newlines +++ b/util/lint/lint-extended-015-final-newlines @@ -18,7 +18,7 @@
PIDS="" INCLUDED_DIRS_AND_FILES='util/* src/* payloads/* configs/* Makefile *.inc' -EXCLUDED_DIRS='src/vendorcode/|util/romcc/|cbfstool/lzma/|cbfstool/lz4/|Documentation/|build/|3rdparty/|.git/|coreboot-builds/|util/nvidia/cbootimage/' +EXCLUDED_DIRS='src/vendorcode/|cbfstool/lzma/|cbfstool/lz4/|Documentation/|build/|3rdparty/|.git/|coreboot-builds/|util/nvidia/cbootimage/' EXCLUDED_FILES='.jpg$|.cksum$|.bin$|.vbt$|.hex$|.ico$|.o$|.bz2$|.xz$|^.tmpconfig|.pyc$|_shipped$|sha256$|.png$|.patch$'
# Use git ls-files if the code is in a git repo, otherwise use find.
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)