[S] Change in coreboot[master]: acpi.c: Fill in >4G FADT entries correctly

[Arthur Heymans (Code Review)]

Attention is currently required from: Felix Held, Kyösti Mälkki, Lance Zhao, Nico Huber, Tim Wawrzynczak.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76179?usp=email )

Change subject: acpi.c: Fill in >4G FADT entries correctly
......................................................................

Patch Set 5:

(2 comments)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/76179/comment/cf3b6d02_290af735 :
PS5, Line 1092: 		fadt->x_firmware_ctl_h = (uint32_t)((uint64_t)(uintptr_t)facs >> 32);
> Wouldn't write shift work here without warnings with just:
>  (uintptr_t)facs >> 32

That results in shift-count-overflow warning/error on 32bit targets. All the casts are to make the compiler happy in both 32 and 64bit cases.

https://review.coreboot.org/c/coreboot/+/76179/comment/a5cd44ff_88738af3 :
PS5, Line 1096: 		fadt->dsdt = (unsigned long)dsdt;
> (uintptr_t) for consistency here?

Done