Attention is currently required from: Tim Wawrzynczak, Julius Werner, Andrey Pronin, Yu-Ping Wu, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58669 )
Change subject: security/vboot: Use default kernel secdata size
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58669/comment/4d1faf66_74cd3869
PS2, Line 22: 20ms
Nice!
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/58669/comment/29df6f99_cc12a01a
PS2, Line 69: ret = TPM_SUCCESS;
Can you move the `ret = ` after the RETURN_ON_FAILURE?
https://review.coreboot.org/c/coreboot/+/58669/comment/9e57dbd6_8966da19
PS2, Line 76: (
nit: no need for the extra ().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22d9c0079bb1175f24ff7317d116e79aa5ba08ed
Gerrit-Change-Number: 58669
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 11 Nov 2021 23:19:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment