Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36718 )
Change subject: soc/intel/tigerlake: Fix cbmem_top ......................................................................
soc/intel/tigerlake: Fix cbmem_top
EBDA support was dropped.
Change-Id: I83d838b79e2653d4e3764cfc7deaca9bb241deab Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/36718/1
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 014606b..8ec4354 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -43,7 +43,7 @@ select SOC_INTEL_COMMON_BLOCK_CHIP_CONFIG select SOC_INTEL_COMMON_BLOCK_CPU select SOC_INTEL_COMMON_BLOCK_CPU_MPINIT - select SOC_INTEL_COMMON_BLOCK_EBDA + select SOC_INTEL_COMMON_BLOCK_SA_FSP_TOLUM select SOC_INTEL_COMMON_BLOCK_GSPI_VERSION_2 select SOC_INTEL_COMMON_BLOCK_HDA select SOC_INTEL_COMMON_BLOCK_SA
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36718 )
Change subject: soc/intel/tigerlake: Fix cbmem_top ......................................................................
Patch Set 1: Code-Review+2
kindly do the same for ICL ?
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36718 )
Change subject: soc/intel/tigerlake: Fix cbmem_top ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
kindly do the same for ICL ?
No need. That is already done for ICL. This slipped by because TGL is not yet build tested.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36718 )
Change subject: soc/intel/tigerlake: Fix cbmem_top ......................................................................
Patch Set 1: Code-Review+2
obvious fix (given that there's no other mention of the EBDA kconfig symbol anywhere in the tree, and the change follows the other disappearances of said symbol), so won't wait the 24h
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36718 )
Change subject: soc/intel/tigerlake: Fix cbmem_top ......................................................................
soc/intel/tigerlake: Fix cbmem_top
EBDA support was dropped.
Change-Id: I83d838b79e2653d4e3764cfc7deaca9bb241deab Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36718 Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/tigerlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 014606b..8ec4354 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -43,7 +43,7 @@ select SOC_INTEL_COMMON_BLOCK_CHIP_CONFIG select SOC_INTEL_COMMON_BLOCK_CPU select SOC_INTEL_COMMON_BLOCK_CPU_MPINIT - select SOC_INTEL_COMMON_BLOCK_EBDA + select SOC_INTEL_COMMON_BLOCK_SA_FSP_TOLUM select SOC_INTEL_COMMON_BLOCK_GSPI_VERSION_2 select SOC_INTEL_COMMON_BLOCK_HDA select SOC_INTEL_COMMON_BLOCK_SA
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36718 )
Change subject: soc/intel/tigerlake: Fix cbmem_top ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36718/1/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/36718/1/src/soc/intel/tigerlake/Kco... PS1, Line 46: select SOC_INTEL_COMMON_BLOCK_SA_FSP_TOLUM Not needed anymore.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36718 )
Change subject: soc/intel/tigerlake: Fix cbmem_top ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36718/1/src/soc/intel/tigerlake/Kco... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/36718/1/src/soc/intel/tigerlake/Kco... PS1, Line 46: select SOC_INTEL_COMMON_BLOCK_SA_FSP_TOLUM
Not needed anymore.
https://review.coreboot.org/c/coreboot/+/36765 for review
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Subrata Banik (Code Review)