Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42703 )
Change subject: mb/amd/mandolin/acpi: drop gpe.asl ......................................................................
mb/amd/mandolin/acpi: drop gpe.asl
Change-Id: I366108334006c81a4d5fb193f583a1e83f7c1456 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- D src/mainboard/amd/mandolin/acpi/gpe.asl M src/mainboard/amd/mandolin/dsdt.asl 2 files changed, 0 insertions(+), 68 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/42703/1
diff --git a/src/mainboard/amd/mandolin/acpi/gpe.asl b/src/mainboard/amd/mandolin/acpi/gpe.asl deleted file mode 100644 index e28edf8..0000000 --- a/src/mainboard/amd/mandolin/acpi/gpe.asl +++ /dev/null @@ -1,65 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -// -// -// -// todo: check file for accuracy -// -// -// - -External (_SB.PCI0.PBR4, DeviceObj) -External (_SB.PCI0.PBR5, DeviceObj) -External (_SB.PCI0.PBR6, DeviceObj) -External (_SB.PCI0.PBR7, DeviceObj) -External (_SB.PCI0.AZHD, DeviceObj) - -Scope(_GPE) { /* Start Scope GPE */ - - /* General event 3 */ - Method(_L03) { - /* DBGO("\_GPE\_L00\n") */ - } - - /* Legacy PM event */ - Method(_L08) { - /* DBGO("\_GPE\_L08\n") */ - } - - /* Temp warning (TWarn) event */ - Method(_L09) { - /* DBGO("\_GPE\_L09\n") */ - /* Notify (_TZ.TZ00, 0x80) */ - } - - /* USB controller PME# */ - Method(_L0B) { - /* DBGO("\_GPE\_L0B\n") */ - Notify(_SB.PCI0.EHC0, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PCI0.XHC0, 0x02) /* NOTIFY_DEVICE_WAKE */ - } - - /* ExtEvent0 SCI event */ - Method(_L10) { - /* DBGO("\_GPE\_L10\n") */ - } - - /* ExtEvent1 SCI event */ - Method(_L11) { - /* DBGO("\_GPE\_L11\n") */ - } - - /* GPIO0 or GEvent8 event */ - Method(_L18) { - /* DBGO("\_GPE\_L18\n") */ - Notify(_SB.PCI0.PBR4, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PCI0.PBR5, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PCI0.PBR6, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PCI0.PBR7, 0x02) /* NOTIFY_DEVICE_WAKE */ - } - - /* Azalia SCI event */ - Method(_L1B) { - /* DBGO("\_GPE\_L1B\n") */ - Notify(_SB.PCI0.AZHD, 0x02) /* NOTIFY_DEVICE_WAKE */ - } -} /* End Scope GPE */ diff --git a/src/mainboard/amd/mandolin/dsdt.asl b/src/mainboard/amd/mandolin/dsdt.asl index 02a6619..4d5d743 100644 --- a/src/mainboard/amd/mandolin/dsdt.asl +++ b/src/mainboard/amd/mandolin/dsdt.asl @@ -45,8 +45,5 @@ #include <soc.asl>
} /* End _SB scope */ - - /* Define the General Purpose Events for the platform */ - #include "acpi/gpe.asl" } /* End of ASL file */
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42703 )
Change subject: mb/amd/mandolin/acpi: drop gpe.asl ......................................................................
Patch Set 1:
this probably needs to be merged before https://review.coreboot.org/c/coreboot/+/41901 since that one removes the EHC0 ACPI device which doesn't exist on Picasso any more
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42703 )
Change subject: mb/amd/mandolin/acpi: drop gpe.asl ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42703 )
Change subject: mb/amd/mandolin/acpi: drop gpe.asl ......................................................................
mb/amd/mandolin/acpi: drop gpe.asl
Change-Id: I366108334006c81a4d5fb193f583a1e83f7c1456 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/42703 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- D src/mainboard/amd/mandolin/acpi/gpe.asl M src/mainboard/amd/mandolin/dsdt.asl 2 files changed, 0 insertions(+), 68 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/acpi/gpe.asl b/src/mainboard/amd/mandolin/acpi/gpe.asl deleted file mode 100644 index e28edf8..0000000 --- a/src/mainboard/amd/mandolin/acpi/gpe.asl +++ /dev/null @@ -1,65 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -// -// -// -// todo: check file for accuracy -// -// -// - -External (_SB.PCI0.PBR4, DeviceObj) -External (_SB.PCI0.PBR5, DeviceObj) -External (_SB.PCI0.PBR6, DeviceObj) -External (_SB.PCI0.PBR7, DeviceObj) -External (_SB.PCI0.AZHD, DeviceObj) - -Scope(_GPE) { /* Start Scope GPE */ - - /* General event 3 */ - Method(_L03) { - /* DBGO("\_GPE\_L00\n") */ - } - - /* Legacy PM event */ - Method(_L08) { - /* DBGO("\_GPE\_L08\n") */ - } - - /* Temp warning (TWarn) event */ - Method(_L09) { - /* DBGO("\_GPE\_L09\n") */ - /* Notify (_TZ.TZ00, 0x80) */ - } - - /* USB controller PME# */ - Method(_L0B) { - /* DBGO("\_GPE\_L0B\n") */ - Notify(_SB.PCI0.EHC0, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PCI0.XHC0, 0x02) /* NOTIFY_DEVICE_WAKE */ - } - - /* ExtEvent0 SCI event */ - Method(_L10) { - /* DBGO("\_GPE\_L10\n") */ - } - - /* ExtEvent1 SCI event */ - Method(_L11) { - /* DBGO("\_GPE\_L11\n") */ - } - - /* GPIO0 or GEvent8 event */ - Method(_L18) { - /* DBGO("\_GPE\_L18\n") */ - Notify(_SB.PCI0.PBR4, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PCI0.PBR5, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PCI0.PBR6, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(_SB.PCI0.PBR7, 0x02) /* NOTIFY_DEVICE_WAKE */ - } - - /* Azalia SCI event */ - Method(_L1B) { - /* DBGO("\_GPE\_L1B\n") */ - Notify(_SB.PCI0.AZHD, 0x02) /* NOTIFY_DEVICE_WAKE */ - } -} /* End Scope GPE */ diff --git a/src/mainboard/amd/mandolin/dsdt.asl b/src/mainboard/amd/mandolin/dsdt.asl index 02a6619..4d5d743 100644 --- a/src/mainboard/amd/mandolin/dsdt.asl +++ b/src/mainboard/amd/mandolin/dsdt.asl @@ -45,8 +45,5 @@ #include <soc.asl>
} /* End _SB scope */ - - /* Define the General Purpose Events for the platform */ - #include "acpi/gpe.asl" } /* End of ASL file */
-
Felix Held (Code Review) -
Raul Rangel (Code Review)