Attention is currently required from: Sean Rhodes, Arthur Heymans.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67076 )
Change subject: soc/intel/apollolake: Communicate with the PMC over Trusted Sideband ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67076/comment/c9d0673c_8ecd2cf8 PS7, Line 11: ``` : intel_punit_ipc intel_punit_ipc.2.auto: Invalid IRQ, using polling mode : intel_punit_ipc intel_punit_ipc.2.auto: invalid resource : ``` I’d just indent the “code” (monospace) parts by four spaces instead of using ```.
https://review.coreboot.org/c/coreboot/+/67076/comment/deb8d5b2_980c9589 PS7, Line 20: You seem to do that in ACPI/ASL. What document is needed to verify your implementation?