Attention is currently required from: Alexander Couzens, Felix Singer.
Alexei Sorokin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80468?usp=email )
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Just wondering, how did you notice? Did something throw an error?
No, I'm suffering from occasional freezes and for the time being blaming native raminit. I've patched MRC support back in and testing it now.
But when I did that I noticed the inconsistency between `usb_port_config` in e7e9502d4673 and how `mainboard_usb_ports` looks today.
If I want to submit MRC support back I should make things consistent. And intentionally worsening the PEI data to align with the current code seems silly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Sorokin
sor.alexei@meowr.ru
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 13 Feb 2024 23:06:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment